Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching to full SPDX license template matching #3

Closed
pmonks opened this issue Oct 28, 2021 · 2 comments
Closed

Consider switching to full SPDX license template matching #3

pmonks opened this issue Oct 28, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@pmonks
Copy link
Owner

pmonks commented Oct 28, 2021

Job Story

When the library is detecting licenses from license texts, I want that logic to use SPDX's matching guidelines, so I can be confident that it is detecting licenses in a way that is consistent with other tools in this space.

Potential Solutions:

SPDX publishes canonical license templates precisely for this purpose. Applying them is not necessarily trivial though, since:

  1. we'd probably want to cache all of the template files on local disk so that we're not re-reading them from the internet on every invocation - there are over 500 of them and they total several MBs in size
  2. it's computationally expensive as every template has to be matched against every single probable license text, to handle the case where multiple license texts have been concatenated into a single license file (yes this does happen in the Java/Clojure ecosystem...) - note however that the current (non-SPDX) logic assumes each text only contains a single license, so this would be a separate "side effect" improvement
@pmonks pmonks transferred this issue from pmonks/tools-licenses Dec 16, 2021
@pmonks pmonks self-assigned this Feb 22, 2023
@pmonks pmonks added the enhancement New feature or request label Feb 22, 2023
@pmonks
Copy link
Owner Author

pmonks commented Feb 22, 2023

This has recently been added to the SPDX Java library, and it is probably better to leverage that functionality rather than rolling a green field implementation in Clojure.

pmonks added a commit that referenced this issue Aug 1, 2023
pmonks added a commit that referenced this issue Aug 13, 2023
pmonks added a commit that referenced this issue Sep 1, 2023
pmonks added a commit that referenced this issue Sep 1, 2023
pmonks added a commit that referenced this issue Sep 2, 2023
pmonks added a commit that referenced this issue Sep 2, 2023
pmonks added a commit that referenced this issue Sep 2, 2023
pmonks added a commit that referenced this issue Sep 3, 2023
pmonks added a commit that referenced this issue Sep 4, 2023
pmonks added a commit that referenced this issue Sep 4, 2023
pmonks added a commit that referenced this issue Sep 4, 2023
pmonks added a commit that referenced this issue Sep 5, 2023
pmonks added a commit that referenced this issue Sep 6, 2023
pmonks added a commit that referenced this issue Sep 6, 2023
pmonks added a commit that referenced this issue Sep 7, 2023
pmonks added a commit that referenced this issue Sep 8, 2023
@pmonks
Copy link
Owner Author

pmonks commented Oct 30, 2023

Fixed in v2.0

@pmonks pmonks closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant