fix(install): do substitution for sites files (ocaml#10327)

Fixes ocaml#10317

The mistake is that the logic is actually more complex that initially
thought: the "executable" status is used to determine is code signing
needs to happen; but artifact substitution should happen in more cases.

Signed-off-by: Etienne Millon <[email protected]>

bin/install_uninstall.ml

@@ -142,7 +142,6 @@ module Special_file = struct
 end
 
 type copy_kind =
-  | Plain (** Just copy the file. Can use fast paths through [Io.copy_file] *)
   | Substitute (** Use [Artifact_substitution.copy_file]. Will scan all bytes. *)
   | Special of Special_file.t (** Hooks to add version numbers, replace sections, etc *)
 
@@ -348,7 +347,6 @@ module File_ops_real (W : sig
       Fiber.return ()
     in
     match kind with
-    | Plain -> plain_copy ()
     | Substitute -> Artifact_substitution.copy_file ~conf ~src ~dst ~chmod ()
     | Special sf ->
       let open Fiber.O in
@@ -515,7 +513,12 @@ let install_entry
       let kind =
         match special_file with
         | Some special -> Special special
-        | None -> if executable then Substitute else Plain
+        | None ->
+          (* CR-emillon: for most cases we could use a fast copy here, but some
+             kinds of files do need artifact substitution(at least
+             executable files and artifacts built from generated sites
+             modules), but it's too late to know without reading the file. *)
+          Substitute
       in
       Ops.copy_file ~src:entry.src ~dst ~executable ~kind ~package ~conf
     in

otherlibs/dune-site/test/install-subst.t

@@ -38,7 +38,3 @@ The generated module has placeholders.
 We expect no placeholders to be present after installation.
 
   $ find out -type f | sort | while read f ; do check_placeholder $f ; done
-  placeholder found in out/lib/a/S.ml
-  placeholder found in out/lib/a/a.a
-  placeholder found in out/lib/a/a.cma
-  placeholder found in out/lib/a/a__S.cmt