fix: Update the cICP implementation yet more #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbowler
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Yes, I think so. The "ignore" list change is certainly correct unless I made a mistake with the ASCII values (perhaps PNG_A, PNG_B etc would help). The png_read_end change seems correct although the bug is harmless. I dislike the whole approach of having to add function calls to multiple places but that's nothing specific to this change.
For the sake of completeness: * Add the cICP entry to the list of known chunks to ignore inside `png_set_keep_unknown_chunks`. * Handle cICP in `png_read_end`, alongside cHRM, gAMA, iCCP, sRGB. * In pngtest.c, move the cICP test code near cHRM, gaMA, iCCP, sRGB. Reviewed-by: John Bowler <[email protected]> Signed-off-by: Cosmin Truta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the sake of completeness:
png_set_keep_unknown_chunks.png_read_end, alongside cHRM, gAMA, iCCP, sRGB.