Revise installation instruction #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tashrifbillah
commented
Dec 6, 2024
•
tashrifbillah
commented
- This revision is primarily motivated by omission of anaconda channel
- Install PyTorch according to official instruction
- Omit repeat install of torch and numpy
- See commit messages
Co-authored-by: Ryan Zurrin <[email protected]>
See comments on this commit in GitHub for details
tashrifbillah
commented
Dec 10, 2024
| @@ -72,7 +72,7 @@ def run_hd_bet(mri_fnames, output_fnames, mode="accurate", config_file=os.path.j | |||
|
|
|||
| params = [] | |||
| for p in list_of_param_files: | |||
| params.append(torch.load(p, map_location=lambda storage, loc: storage)) | |||
| params.append(torch.load(p, map_location=lambda storage, loc: storage, weights_only=True)) | |||
There was a problem hiding this comment.
pytorch raises an warning, prompting to effect this change.
tashrifbillah
commented
Dec 10, 2024
|
|
||
| # please refer to the readme on where to get the parameters. Save them in this folder: | ||
| folder_with_parameter_files = os.path.join(os.path.expanduser('~'), 'hd-bet_params') |
There was a problem hiding this comment.
This was downloading model for everybody consuming space.
RyanZurrin
approved these changes
Dec 13, 2024
This was referenced Jan 6, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.