This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
Fixed using Connect-PnPOnline -AppId -AppSecret -AADDomain #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly authenticating
KoenZomers
added
the
status:checked and ready for merge ✔
6 tasks
|
This PR unfortunately does not compile. It's missing definitions for GraphAADLogin and AADDomain. |
erwinvanhunen
added
Needs: Attention 👋
and removed
status:checked and ready for merge ✔
|
Having a look at it now @erwinvanhunen |
|
It had gotten a merge conflict as @wobba applied a fix directly to dev for the same issue after I filed this PR. Rebased this PR onto the current dev to include his change and applied the fix as I proposed it initially as it includes a bigger cleanup of the Graph authentication. |
KoenZomers
added
the
status:checked and ready for merge ✔
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
N/A
What is in this Pull Request ?
Fixed using Connect-PnPOnline -AppId -AppSecret -AADDomain not actually authenticating. Now it does authenticate using the appid and appsecret to Microsoft Graph and you can use the Microsoft Graph commands and Get-PnPAccessToken again with it.