Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing X509 object to OnBehalfOfAuthenticationProvider #1046

Closed
1 task done
rlv-dan opened this issue Dec 6, 2022 · 3 comments
Closed
1 task done

Support passing X509 object to OnBehalfOfAuthenticationProvider #1046

rlv-dan opened this issue Dec 6, 2022 · 3 comments
Assignees
@mloitzl
Labels
area: authentication Authentication related help wanted Extra attention is needed

Comments

@rlv-dan
Copy link

rlv-dan commented Dec 6, 2022

Category

  • Feature request

Describe the feature

When creating an X509CertificateAuthenticationProvider you can either provide StoreName/StoreLocation/Thumbprint or a ready X509Certificate2 object. Great! Another provider I was using is OnBehalfOfAuthenticationProvider. But this only accepts the StoreName/StoreLocation/Thumbprint parameters, not a certificate object.

Originally posted by @rlv-dan in #897 (comment)

Describe the solution you'd like

Allow creation of OnBehalfOfAuthenticationProvider with an X509Certificate2 object in addition to Thumbprint
@jansenbe jansenbe added help wanted Extra attention is needed area: authentication Authentication related labels Dec 6, 2022
@mloitzl
Copy link
Contributor

mloitzl commented Dec 6, 2022

@jansenbe I could have a look at this one...

@jansenbe
Copy link
Contributor

jansenbe commented Dec 7, 2022

Thanks for helping out @mloitzl 💪🚀

@mloitzl mloitzl mentioned this issue Dec 7, 2022
Merged
@jansenbe
Copy link
Contributor

jansenbe commented Dec 9, 2022

Thanks for your PR @mloitzl ! @rlv-dan , you can use this using the next nightly build (version 1.8.33 or higher). Closing issue now, feel free to re-open in case needed

@jansenbe jansenbe closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mloitzl mloitzl

Labels
area: authentication Authentication related help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jansenbe @rlv-dan @mloitzl