Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell us what is missing in PnP Core SDK / what feature would you like to see added #897

Closed
jansenbe opened this issue Jun 24, 2022 · 17 comments
Labels
area: model 📐 Related to the core SDK models

Comments

@jansenbe
Copy link
Contributor

To further grow PnP Core SDK we'd like to understand what features you'd like to see added to PnP Core SDK. If you've need a feature in your project or you've suggestions for features to add then please create a new issue in our issue list so that we can track your ask.

@jansenbe jansenbe added the area: model 📐 Related to the core SDK models label Jun 24, 2022
@jansenbe jansenbe pinned this issue Jun 24, 2022
@pnp pnp deleted a comment from valpvt Aug 26, 2022
@gautamdsheth
Copy link
Collaborator

Feature request:

Add capability to easily add Quick Links webpart on a page, similar to Image or Text webpart.
Here, we will be able to define Link URL, Thumbnail Image or Icon , Alt text and maybe if possible order of showing links in the webpart.

I would be happy to add a new cmdlet like - Add-PnPPageQuickLinksWebpart or something like that in PnP PowerShell.

@valpvt
Copy link
Contributor

valpvt commented Sep 30, 2022

Feature request :
Add capability to retrieve Private Channel Sites (like in Pnp PowerShell).
Best regards

@joshmiller1FEI
Copy link

joshmiller1FEI commented Oct 20, 2022

with SharePointPnPCoreOnline I could connect Without a clientID

var authManager = new OfficeDevPnP.Core.AuthenticationManager();
            ClientContext ctx = authManager.GetWebLoginClientContext("https://example.sharepoint.com/sites/example");
            Web web = ctx.Web;
            ctx.Load(web);
            ctx.ExecuteQuery();

How can I achieve the above with the new pnp.core ?

The new Minimal Console Example here requires registration of an AAD App and subsequent Client ID.

thank you
Josh

@jansenbe
Copy link
Contributor Author

@joshmiller1FEI : the web login approach indeed is not in PnP Core SDK and that's by design, we're also not supporting Azure ACS anymore in PnP Core SDK. Both approaches are legacy authentication models, the only future proof authentication model for SharePoint is via OAuth and an Azure AD application.

@fowl2
Copy link

fowl2 commented Oct 26, 2022

@jansenbe Azure AD authentication still doesn't have feature parity with ACS. For example:

  • Site collection admins can't grant permissions, only tenant admins.
  • There's no UI for granting granular (site or list level) permissions.
  • Only certificates are supported, not secrets.

@jansenbe
Copy link
Contributor Author

Thanks for the feedback @fowl2. You're absolutely right in those, Sites.Selected has no UI in Azure AD and you need a tenant admin or a highly privileged application to configure it. We're aware of these shortcomings and evaluating improvements, however there's no confirmed plans yet and no timeline to share.

Regarding the need for certificates: yes, this is by design for calling SharePoint REST or CSOM APIs when using application permissions. If your application only uses Microsoft Graph calls, then a secret is sufficient. I'm not aware of any current plans to also allow a secret for calling SharePoint REST/CSOM using application permissions.

@mloitzl
Copy link
Contributor

mloitzl commented Nov 4, 2022

Hi @jansenbe,

In one of my past projects we somehow missed the ability to get terms by custom property, like in the good old TermSet.GetTermsWithCustomProperty(CustomPropertyMatchInformation) Method

I played around with this implementation in this fork of PnP Core and it somehow works:

https://github.com/mloitzl/pnpcore/tree/feature/termsbycustomproperty

Do you think this has potential to get into the PnP Core Library?

@jansenbe
Copy link
Contributor Author

jansenbe commented Nov 4, 2022

@mloitzl : I've taken a quick peek on the code and looks good. Can you please submit a PR?

@jansenbe
Copy link
Contributor Author

jansenbe commented Nov 4, 2022

@gautamdsheth : with the new page API coming I don't see a need for that.

@jansenbe
Copy link
Contributor Author

jansenbe commented Nov 4, 2022

@valpvt : can you elaborate a bit more on how you see this?

@eduardpaul
Copy link

eduardpaul commented Nov 10, 2022

Hi @jansenbe, it would be very interesting to include in pnp core the possibility to expand some fields during a list query (or if it exists, the documentation on how to use it 😄). Ex.: expand user field to get email/principal/sip... using rest API it's only one request but using pnp core we need to get the items and then create a batch to get the properties that we need.
Also, there is an older discussion that describe exactly the same: #382

@rlv-dan
Copy link

rlv-dan commented Dec 6, 2022

I just noticed an omission that you might want to implement for completions sake:

When creating an X509CertificateAuthenticationProvider you can either provide StoreName/StoreLocation/Thumbprint or a ready X509Certificate2 object. Great! Another provider I was using is OnBehalfOfAuthenticationProvider. But this only accepts the StoreName/StoreLocation/Thumbprint parameters, not a certificate object.

@jansenbe
Copy link
Contributor Author

jansenbe commented Dec 6, 2022

Makes sense @rlv-dan , can you create a new issue for this so we can more easily track it. Thx!

@valpvt
Copy link
Contributor

valpvt commented Dec 7, 2022

@valpvt : can you elaborate a bit more on how you see this?

@jansenbe PnP Powershell relies on the hidden list at the admin site collection level and allows to get private channel sites. It seems like PnP Core SDK does not query this list because it does not retrieve private channel sites when using a service principal identity

@larry-lau
Copy link

Feature request :
Add the capability to approve permission requests like m365 cli
m365 spo serviceprincipal permissionrequest approve

We are able to use pnpcore to deploy SPFx app to app catalog. However, the app request permission to call Graph API.
The only step we couldn't automate is the permission requests approval step.

@jansenbe
Copy link
Contributor Author

Feature request : Add the capability to approve permission requests like m365 cli m365 spo serviceprincipal permissionrequest approve

We are able to use pnpcore to deploy SPFx app to app catalog. However, the app request permission to call Graph API. The only step we couldn't automate is the permission requests approval step.

Thanks @larry-lau , that's a useful add. I've created a new issue to track this.

@jansenbe
Copy link
Contributor Author

Closing this issue as it's not an ideal way to deal with feature asks. Please just create a new issue if you feel something is missing

@jansenbe jansenbe unpinned this issue Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: model 📐 Related to the core SDK models
Projects
None yet
Development

No branches or pull requests

9 participants