Feature request : Add the capability to approve permission requests like m365 cli m365 spo serviceprincipal permissionrequest approve

[jansenbe]

          Feature request :

Add the capability to approve permission requests like m365 cli
m365 spo serviceprincipal permissionrequest approve

We are able to use pnpcore to deploy SPFx app to app catalog. However, the app request permission to call Graph API.
The only step we couldn't automate is the permission requests approval step.

Originally posted by @larry-lau in #897 (comment)

[mloitzl]

@jansenbe I had a quick look at it.

• The CSOM queries could be taken straight from the m365 cli project
• I am not quite sure where this should go... - I reckon somewhere in PnP.Core.Admin, but this would need a new Model... probably ServicePrincipal or SPOServicePrincipal and at least some functionality for PermissionRequests list, approve and deny? I never extended model before...

[jansenbe]

@mloitzl : yes, this would require a new model in PnP.Core.Admin, think that's the easiest and most reusable approach. Regarding the CSOM queries: in cli they are quite hardcoded, in PnP Core SDK we use a different model, one that allows to batch CSOM queries. If there's no REST/Graph equivalent for the API calls then CSOM has to be used by using our model. See https://github.com/pnp/pnpcore/tree/dev/src/sdk/PnP.Core.Admin/Services/Core/CSOM/Requests/Tenant for some sample CSOM operations.

[mloitzl]

@jansenbe Didn't have that much time this week... but here's a draft
#1100

[jansenbe]

@mloitzl : awesome! Thanks for helping out 💪🚀Will review the PR early next week.

[jansenbe]

@mloitzl : just reviewed and merged your PR, great job! Thanks a lot for your contribution to PnP Core SDK!!!

@larry-lau: please try this feature with the next nightly release (version 1.8.107 or higher). See https://pnp.github.io/pnpcore/using-the-sdk/admin-sharepoint-apps.html#list-approve-or-reject-the-permissions-requests-for-an-app for the docs.

Will close this issue now, please create new issue if things are not working @larry-lau, thank you @mloitzl for building the feature.

[larry-lau]

Thank you for implementing the feature so quickly. However, the ServicePrincipal class is internal so I am not able to instantiate.

[mloitzl]

Oops... that's a very obvious one 😆
I'll come up with a fix during the weekend

[jansenbe]

@larry-lau : thanks for spotting that one @larry-lau and thanks for the fix @mloitzl . Our test project can see the internals of PNP Core SDK, hence this passed our checks.

[larry-lau]

Thanks! Which nightly build would have the new getter on IAppManager so I can test this out?

[jansenbe]

The one out now

[larry-lau]

I have tested the API. Looking good. I would suggest renaming IPermissionRequest.PackageApproverName to RequesterName