Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft 365 "POL" GeoLocation Missing #1232

Closed
1 task done
Sean-LM opened this issue Jul 19, 2023 · 1 comment
Closed
1 task done

Microsoft 365 "POL" GeoLocation Missing #1232

Sean-LM opened this issue Jul 19, 2023 · 1 comment
Assignees
Labels
area:admin 📜 Admin library related

Comments

@Sean-LM
Copy link

Sean-LM commented Jul 19, 2023

Category

  • Bug

Describe the bug

The POL GeoLocation is missing.

Steps to reproduce

  1. Reference the Microsoft Documentation here: https://learn.microsoft.com/en-us/microsoft-365/enterprise/microsoft-365-multi-geo?view=o365-worldwide#microsoft-365-multi-geo-availability
  2. Reference the PnP Core GeoLocation enum here: https://github.com/pnp/pnpcore/blob/dev/src/sdk/PnP.Core.Admin/Model/Microsoft365/Public/Enums/GeoLocation.cs
  3. Observe that POL is missing in the PnP Code enum.

Expected behavior

The POL GeoLocation should be present and available for operations in the library.

Environment details (development & target environment)

n/a

Additional context

n/a

Thank you! If this is as simple as adding an entry to the GeoLocation enum (I don't see any specific country mentions in the code, but did not dig deeply), I can open a PR. I do not know the side-effects internally of such an addition.

jansenbe added a commit that referenced this issue Jul 19, 2023
@jansenbe jansenbe self-assigned this Jul 19, 2023
@jansenbe jansenbe added the area:admin 📜 Admin library related label Jul 19, 2023
@jansenbe
Copy link
Contributor

Thanks for raising this @Sean-LM , I've added a fix which will be part of the next nightly build, closing the issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:admin 📜 Admin library related
Projects
None yet
Development

No branches or pull requests

2 participants