Access Token Log Not Formatted Correctly

[randellhodges]

Category

• Bug

Describe the bug

The access token log entry looks like it isn't formatted correctly.

Text:

JSON:

It seems like 0 and 2 are backwards (maybe this is a Serilog problem?) and the scope needs the leading ", " trimmed.

Code in question:

pnpcore/src/sdk/PnP.Core.Auth/Confidential/X509CertificateAuthenticationProvider.cs

Lines 193 to 195 in e2e579f

	// Log the access token retrieval action
	Log?.LogInformation(PnPCoreAuthResources.AuthenticationProvider_LogAccessTokenRetrieval,
	GetType().Name, resource, scopes.Aggregate(string.Empty, (c, n) => c + ", " + n).TrimEnd(','));

Steps to reproduce

1. Use Serilog
2. Use Certificate Authentication
3. Set log for Information

Environment details (development & target environment)

• SDK version: 1.10.0
• OS: Windows
• SDK used in: Net Core 6 Web Api
• Framework: .Net Core 6
• Tooling: Visual Studio 2022

Additional context

Secondary question: Can we have a way to turn off those messages? I still want to leave the log level for Information because I need to watch for throttling messages and other things, but my logs are flooded with these access token entries. Maybe some sort of property on the PnpCoreAuthenticationOptions?

[jansenbe]

@randellhodges : the ordering is seems to be something with Serilog. When we bump serilog versions this might get fixed, but don't see this a breaking thing.

Regarding the default log level for the "access token" messages you've a point. I changed those to default to debug level.

Changes will appear in the next nightly.