-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALM feature. #601
ALM feature. #601
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #601 +/- ##
==========================================
+ Coverage 75.32% 82.00% +6.67%
==========================================
Files 257 400 +143
Lines 19708 27475 +7767
==========================================
+ Hits 14846 22532 +7686
- Misses 4862 4943 +81
Continue to review full report at Codecov.
|
Awesome work @s-KaiNet . I plan to review and process this PR in the coming days, super happy you've been helping out here 💪🥇🚀🎉 |
@s-KaiNet : just merged your PR. I'm truly impressed by the work you've done!! Very clean and well written code, super test coverage and documentation 🎉 Congrats on this great PR. Hope you enjoyed doing it, you've managed to find your way in PnP Core SDK but if you've ideas about possible improvements then don't hesitate to call them out. I could successfully run all but one test against my lab tenant: |
woohoo! thanks @jansenbe! I have a bit more free time now and, maybe will have it for a few upcoming months, thus I'm glad to contribute to other PnP Core SDK areas as well. I see issues with the "help wanted" tag and planning to start working on any of them next. Most likely it will be #217. If you have any prioritization among issues, then please suggest which one should I work and I will work on it instead. |
@s-KaiNet : Thank you SO much, man. While my current project doesn't require anything with Apps, it is definitely something we use often. This is a great PR and I'm very thankful for it. |
Thanks for the nice words @DaleyKD 👍 @s-KaiNet : Contributing to PnP Core SDK is something you do in your spare time and I'm grateful you're helping out with PnP Core SDK. Feel free to pick any of the current issues or alternatively propose new areas: for example in the admin space there's still areas to cover. For the most important thing is that you pick something you enjoy working on. The goal is to overtime make this an established .NET SDK for SharePoint+Teams development, without depending on the CSOM packages. In contrast with PnP Framework (and previously PnP Sites Core) the focus here is on performance, quality, test coverage and documentation...eventually this library will have enough features to allow for a deprecation of PnP Framework. |
Thanks! Then the webhooks will be a nice feature to implement, cause I have some experience with hooks. I love the idea of having a separate library to cover SharePoint and Teams. I remember some time ago there was a plan to open-source SharePoint CSOM. I can imagine how complicated the code inside CSOM is, how much legacy stuff is in there. It's not possible to contribute to such a library at all. Maybe it's good that it's not open-sourced :). From my understanding in the future, PnP Core SDK will become the "new CSOM" and "new PnP Framework". But a lot more stable and easier to contribute to. And that's cool. |
This PR adds ALM support to the PnP Core.
As discussed in the linked issue:
GetTenantAppManager
andGetSiteCollectionAppManager
AppManager
class with core functionalityDeploy
,Install
, etc. methods directly.Feel free to add any comments, suggestions, corrections, etc. even if it requires a full code rewrite from my side. This is my very first big PR to the PnP Core library, so I'm just learning :)
Closes #215