Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit Catch of System.IO.IOException in ExecuteQueryImplementation… #301

Merged
merged 4 commits into from
May 3, 2021

Conversation

czullu
Copy link
Contributor

@czullu czullu commented May 1, 2021

#292 Took the Idea with TraceCorrelationId and write this to log by handling IOExpection explicit,
also handle TimeOut with explicit message. Lets see if i can get some input for SSL from Application Insight like this.

@jansenbe
Copy link
Contributor

jansenbe commented May 3, 2021

Thanks @czullu , adding more logging and resilience when it comes to socket exceptions/ timeouts makes sense.

@jansenbe jansenbe self-assigned this May 3, 2021
@jansenbe jansenbe added the area: other 🎁 Miscellaneous issue or pull request label May 3, 2021
jansenbe added a commit that referenced this pull request May 3, 2021
@jansenbe jansenbe merged commit 14af188 into pnp:dev May 3, 2021
@czullu czullu deleted the Enhance_ExecuteQueryImplementation branch October 19, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: other 🎁 Miscellaneous issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants