Changes around Classification and Sensitivity Labels #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 25, 2022 09:32
…o better suit its goal
added 5 commits
June 27, 2022 02:55
|
@KoenZomers - Some of these cmdlets are missing |
|
@gautamdsheth Yes. Mainly because of how this has been developed within PnP. As we may execute these cmdlets using a delegate and an app only token, it would require different permissions for either of them. If we specify that attribute, it will error out if we use the other one since it will be missing from the scp in our access token. We would need something where we can specify if it works for delegate tokens and app only tokens. Fairly easy to implement and I believe it was like this originally but at one point Erwin decided to simplify the permissions leaving just this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
N/A
What is in this Pull Request ?
Went through the entire situation around Site Classification and Sensitivity Labels and rewrote it.