Changes to Get-PnPSiteCollectionAppCatalogs

[KoenZomers]

Type

• Bug Fix
• New Feature
• Sample

Related Issues?

Fixes #2041

What is in this Pull Request ?

• Renamed Get-PnPSiteCollectionAppCatalogs to Get-PnPSitecollectionAppCatalog to follow our naming convention
• Changed so that Get-PnPSitecollectionAppCatalog now returns our own model
• Every returned site will be validated if it still exists and about the actual current URL
• Added -ExcludeDeletedSites optional parameter to Get-PnPSiteCollectionAppCatalogs which allows for site collections with App Catalogs that are in the recycle bin to be exluded from the results
• Added -CurrentSite optional parameter to Get-PnPSiteCollectionAppCatalogs which allows for checking if the currently connected to site has a site collection App Catalogs provisioned on it

[gautamdsheth]

Hey @KoenZomers , lets not introduce breaking changes here.

Lets just return whatever CSOM is returning instead of our own object.

Consider this scenario:

$appCatalogSites = Get-PnPSiteCollectionAppCatalog
$appCatalogSites[0]

Now, if $appCatalogSites[0] has some property, like $appCatalogSites[0].Title that is being used by users, it will be broken.

Same goes for the page, lets keep the URL as it was before.
People do keep that as bookmarks and suddenly they will find that its not working.
The alias is good , once we remove that Alias, we will change the page URL as well