Added warning in the catch block #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoenZomers
reviewed
Mar 14, 2023
src/Commands/Files/MoveFile.cs
Outdated
| { | ||
| WriteWarning(ex.Message); |
There was a problem hiding this comment.
I understand why you want to visualize this situation, not sure yet if warning is the best method for this as it may break automated builds that are using this today. Verbose might be a safer option. @gautamdsheth What's your take on this?
There was a problem hiding this comment.
Yeah, WriteVerbose is the safer option for this exception, we don't want to break scripts.
There was a problem hiding this comment.
All right thank you for you feedback - I'll change it and update the branch
ChrisRo89
requested review from
KoenZomers and
gautamdsheth
and removed request for
KoenZomers and
gautamdsheth
…nd to also show verbose output on what its doing when things do go well
|
Thanks @ChrisRo89 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before creating a pull request, make sure that you have read the contribution file located at
https://github.com/pnp/powerShell/blob/dev/CONTRIBUTING.md
Type
Added warning message for catch block related to MoveFile