Fix AccessToken scope for vanity domains #4630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticed that I need to change the order. The reason it actually still worked, is because it reverts to the old logic that had no scopes at all. |
|
Should be ok now |
|
LGTM , thanks a lot @jhholm for this PR , merged it, much appreciated ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Fixes #4594, probably fixes pnp/pnpframework#1091
What is in this Pull Request ?
The issue in #4594 is caused by calling GetAccessTokenAsync with "https://{resource}", but the logic behind the function is different between the overloaded implementations. Vanity domains will call string[] overload implementation and regular sharepoint domains will call string overload implementation of GetAcccessTokenAsync.
string overload appends './default' to scope
https://github.com/pnp/pnpframework/blob/569dd302a080d26ae21f098c0af2b70e398a8968/src/lib/PnP.Framework/AuthenticationManager.cs#L763
string[] overload doesn't append './default' to the scopes
https://github.com/pnp/pnpframework/blob/569dd302a080d26ae21f098c0af2b70e398a8968/src/lib/PnP.Framework/AuthenticationManager.cs#L806