Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PropertyFieldOrder] Appending to an array doesn't reflect in order #81

Closed
1 of 3 tasks
Katli95 opened this issue Jul 17, 2018 · 3 comments
Closed
1 of 3 tasks
Assignees

Comments

@Katli95
Copy link

Katli95 commented Jul 17, 2018

Category

  • Enhancement
  • Bug
  • Question
    Pretty sure this is a bug because I'd expect changing the property would affect this field

Version: [1.8.0]

Expected / Desired Behavior

I expected to be able to sort an array that drew it's contents from the PropertyFieldMultiSelect field.

Observed Behavior

Once I choose an option with the PropertyFieldMultiSelect it doesn't show up in the PropertyFieldOrder until I refresh my browser window. (all of this is on a hosted SP workbench.

Steps to Reproduce

  1. Add both of these field controls and connect them to the same property.
  2. Try selecting items from the MultiSelect and see if the OrderField updates

quick sidenote:
My actual flow is actually slightly more complicated as I am dynamically loading up the MultiSelect options with the @pnp/sp library.

Thanks!

@estruyf estruyf added the bug label Jul 30, 2018
@estruyf estruyf assigned estruyf and thechriskent and unassigned estruyf Jul 30, 2018
@estruyf
Copy link
Member

estruyf commented Jul 30, 2018

Thanks @Katli95 for reporting this.

@thechriskent could you check this one?

estruyf added a commit that referenced this issue Aug 9, 2018
@estruyf
Copy link
Member

estruyf commented Aug 9, 2018

@Katli95 the issue got fixed and will be in version 1.9.0 of the controls release.

Here you can see the result:
orderfield-async

You can always test out the latest beta: https://sharepoint.github.io/sp-dev-fx-property-controls/beta/

@estruyf estruyf closed this as completed Aug 9, 2018
@Katli95
Copy link
Author

Katli95 commented Aug 9, 2018

Awesome! Love the work your doing and look forward to participating myself. I would have fixed the issue myself but I feel reluctant to alter any of the source code as I've only been working in Web Development since the SPFx got released in February last year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants