Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggestion to apply patch on Windows using command shell is wrong #7546

Closed
2 of 4 tasks
userquin opened this issue Jan 21, 2024 · 0 comments · Fixed by #8851
Closed
2 of 4 tasks

suggestion to apply patch on Windows using command shell is wrong #7546

userquin opened this issue Jan 21, 2024 · 0 comments · Fixed by #8851
Labels
type: bug

Comments

@userquin
Copy link

userquin commented Jan 21, 2024 •
edited
Loading

Verify latest release

  • I verified that the issue exists in the latest pnpm release

pnpm version

8.14.1

Which area(s) of pnpm are affected? (leave empty if unsure)

CLI

Link to the code that reproduces this issue or a replay of the bug

https://github.com/elk-zone/elk

Reproduction steps

D:\work\elk-org\elk-nuxt-3.9>pnpm patch [email protected]  
You can now edit the following folder: C:\Users\JOAQUN~1\AppData\Local\Temp\f275b8e094bec98fbb299d3e188eca53

Once you're done with your changes, run "pnpm patch-commit 'C:\Users\JOAQUN~1\AppData\Local\Temp\f275b8e094bec98fbb299d3e188eca53'"

D:\work\elk-org\elk-nuxt-3.9>pnpm patch-commit 'C:\Users\JOAQUN~1\AppData\Local\Temp\f275b8e094bec98fbb299d3e188eca53'
 ENOENT  ENOENT: no such file or directory, open 'D:\work\elk-org\elk-nuxt-3.9\'C:\Users\JOAQUN~1\AppData\Local\Temp\f275b8e094bec98fbb299d3e188eca53'\package.js
on'

Removing single quotes around the folder path works:

D:\work\elk-org\elk-nuxt-3.9>pnpm patch-commit C:\Users\JOAQUN~1\AppData\Local\Temp\f275b8e094bec98fbb299d3e188eca53  
 WARN  7 deprecated subdependencies found: @babel/[email protected], @babel/[email protected], [email protected].
0, [email protected], [email protected], [email protected], [email protected]

Describe the Bug

The patch cannot be applied.

Expected Behavior

The patch should be applied.

Which Node.js version are you using?

Node 20.10.0 LTS

Which operating systems have you used?

  • macOS
  • Windows
  • Linux

If your OS is a Linux based, which one it is? (Include the version if relevant)

No response
@userquin userquin changed the title suggestioon to apply patch on Windows using command shell is wrong suggestion to apply patch on Windows using command shell is wrong Jan 21, 2024
otomad added a commit to otomad/pnpm that referenced this issue Dec 9, 2024
@otomad
fix: command suggestion to apply patch on Windows
1794f38 
fix pnpm#7546
@otomad otomad mentioned this issue Dec 9, 2024
Merged
zkochan added a commit that referenced this issue Dec 20, 2024
@otomad @zkochan
fix: command suggestion to apply patch on Windows (#8851)
f74070d 
close #7546

---------

Co-authored-by: Zoltan Kochan <[email protected]>
zkochan added a commit that referenced this issue Dec 20, 2024
@otomad @zkochan
fix: command suggestion to apply patch on Windows (#8851)
5879386 
close #7546

---------

Co-authored-by: Zoltan Kochan <[email protected]>
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this issue Dec 28, 2024
@renovate
chore(deps): update pnpm to v9.15.2
4ecf264 
##### [v9.15.2](https://github.com/pnpm/pnpm/releases/tag/v9.15.2)

#### Patch Changes

-   Fixed `publish`/`pack` error with workspace dependencies with relative paths [#8904](pnpm/pnpm#8904). It was broken in `v9.4.0` ([398472c](pnpm/pnpm@398472c)).
-   Use double quotes in the command suggestion by `pnpm patch` on Windows [#7546](pnpm/pnpm#7546).
-   Do not fall back to SSH, when resolving a git-hosted package if `git ls-remote` works via HTTPS [#8906](pnpm/pnpm#8906).
-   Improve how packages with blocked lifecycle scripts are reported during installation. Always print the list of ignored scripts at the end of the output. Include a hint about how to allow the execution of those packages.

#### Platinum Sponsors

<table>
  <tbody>
    <tr>
      <td align="center" valign="middle">
        <a href="https://bit.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://pnpm.io/img/users/bit.svg" width="80" alt="Bit"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://sanity.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://pnpm.io/img/users/sanity.svg" width="180" alt="Bit"></a>
      </td>
      <td align="center" valign="middle">
        <a href="https://figma.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank"><img src="https://pnpm.io/img/users/figma.svg" width="80" alt="Figma"></a>
      </td>
    </tr>
  </tbody>
</table>
#### Gold Sponsors

<table>
  <tbody>
    <tr>
      <td align="center" valign="middle">
        <a href="https://discord.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank">
          <picture>
            <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/discord.svg" />
            <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/discord_light.svg" />
            <img src="https://pnpm.io/img/users/discord.svg" width="220" alt="Discord" />
          </picture>
        </a>
      </td>
      <td align="center" valign="middle">
        <a href="https://prisma.io/?utm_source=pnpm&utm_medium=release_notes" target="_blank">
          <picture>
            <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/prisma.svg" />
            <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/prisma_light.svg" />
            <img src="https://pnpm.io/img/users/prisma.svg" width="180" alt="Prisma" />
          </picture>
        </a>
      </td>
    </tr>
    <tr>
      <td align="center" valign="middle">
        <a href="https://uscreen.de/?utm_source=pnpm&utm_medium=release_notes" target="_blank">
          <picture>
            <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/uscreen.svg" />
            <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/uscreen_light.svg" />
            <img src="https://pnpm.io/img/users/uscreen.svg" width="180" alt="u|screen" />
          </picture>
        </a>
      </td>
      <td align="center" valign="middle">
        <a href="https://www.jetbrains.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank">
          <picture>
            <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/jetbrains.svg" />
            <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/jetbrains.svg" />
            <img src="https://pnpm.io/img/users/jetbrains.svg" width="180" alt="JetBrains" />
          </picture>
        </a>
      </td>
    </tr>
    <tr>
      <td align="center" valign="middle">
        <a href="https://nx.dev/?utm_source=pnpm&utm_medium=release_notes" target="_blank">
          <picture>
            <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/nx.svg" />
            <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/nx_light.svg" />
            <img src="https://pnpm.io/img/users/nx.svg" width="120" alt="Nx" />
          </picture>
        </a>
      </td>
      <td align="center" valign="middle">
        <a href="https://coderabbit.ai/?utm_source=pnpm&utm_medium=release_notes" target="_blank">
          <picture>
            <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/coderabbit.svg" />
            <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/coderabbit_light.svg" />
            <img src="https://pnpm.io/img/users/coderabbit.svg" width="220" alt="CodeRabbit" />
          </picture>
        </a>
      </td>
    </tr>
    <tr>
      <td align="center" valign="middle">
        <a href="https://route4me.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank">
          <img src="https://pnpm.io/img/users/route4me.svg" width="220" alt="Route4Me" />
        </a>
      </td>
      <td align="center" valign="middle">
        <a href="https://workleap.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank">
          <picture>
            <source media="(prefers-color-scheme: light)" srcset="https://pnpm.io/img/users/workleap.svg" />
            <source media="(prefers-color-scheme: dark)" srcset="https://pnpm.io/img/users/workleap_light.svg" />
            <img src="https://pnpm.io/img/users/workleap.svg" width="190" alt="Workleap" />
          </picture>
        </a>
      </td>
    </tr>
    <tr>
      <td align="center" valign="middle">
        <a href="https://canva.com/?utm_source=pnpm&utm_medium=release_notes" target="_blank">
          <img src="https://pnpm.io/img/users/canva.svg" width="120" alt="Canva" />
        </a>
      </td>
    </tr>
  </tbody>
</table>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: command suggestion to apply patch on Windows otomad/pnpm
1 participant
@userquin