Relax OAuth2 RedirectUrl validation #3689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current validation prohibits custom url schemes, which breaks custom url schemes common in mobile apps. Let OAuth2 provider handle redirect url validation instead.
|
Could you also add a test with a custom url scheme in the Side-note: when using the "all-in-one" OAuth2 flow you don't need a deeplink, although I guess it will depend on the SDK implementation. |
ganigeorgiev
added a commit
that referenced
this pull request
Nov 6, 2023
…g value Co-authored-by: sergeypdev <[email protected]>
|
I've squash merged the changes in |
|
@ganigeorgiev thank you! |
abdokhaire
pushed a commit
to abdokhaire/postgresbase
that referenced
this pull request
Aug 7, 2024
… any string value Co-authored-by: sergeypdev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, first of all thanks for making PocketBase!
I encountered an issue with OAuth2 when implementing auth in iOS. Current RedirectUrl validation is too restrictive and doesn't allow custom url schemes, which is needed for native apps.
I think it's best to disable that validation on the PocketBase side, because it's not really necessary there. Let the OAuth provider handle that instead in their own way.