SocketReactor: Remove not useful handlers calls

[aleks-f]

There are handler calls in the SocketReactor::run() that are of no use (onIdle()), or little use (onBusy()).

These calls will be removed from SocketReactor::run(). Subscribers to these events will have to overide the run() function to keep the functionality.

[micheleselea]

onIdle and onBusy handlers, can be usefull to handle a dead socket, for example a socket that do not send you nothing for X seconds. That was the main reason I use it now

[zosrothko]

Agreed with @micheleselea . One need a way to smoothly cleanup the socket space otherwise, one could get an exhaust exception

[aleks-f]

I'm not following, onIdle() was called when there are no socket handlers - who's there to handle the idle notification?

When there are registered handlers but no activity, there is timeout notification:

poco/Net/include/Poco/Net/SocketReactor.h

Lines 88 to 92 in 5c3f827

	/// If the poll timeout expires and no event has occurred, a
	/// TimeoutNotification will be dispatched to all event handlers
	/// registered for it. This is done in the onTimeout() method
	/// which can be overridden by subclasses to perform custom
	/// timeout processing.

[aleks-f]

In any case, SocketReactor is a Runnable, which means user can override the run() to do whatever necessary for their requirements - we can't be all things to all people.

[micheleselea]

yes @aleks-f you are right, it's onBusy that do the "socket checker" in my project and I already had to extend the SocketReacor

[github-actions]

This issue is stale because it has been open for 365 days with no activity.

[github-actions]

This issue was closed because it has been inactive for 60 days since being marked as stale.