Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional and Nullable Improvements #4502

Closed
aleks-f opened this issue Mar 19, 2024 · 1 comment · Fixed by #4700
Closed

Optional and Nullable Improvements #4502

aleks-f opened this issue Mar 19, 2024 · 1 comment · Fixed by #4700
Assignees
@matejk
Labels
enhancement
Milestone
Release 1.14.0

Comments

@aleks-f
Copy link
Member

aleks-f commented Mar 19, 2024 •
edited
Loading

  • Optional in terms of std::optional
  • Nullable should be implemented in terms of std::unique_ptr<T>
  • NullType should be nullptr_t (or at least a static const)
  • tests
@aleks-f aleks-f added this to the Release 1.14.0 milestone Mar 19, 2024
@aleks-f aleks-f added this to 1.14 Mar 19, 2024
@obiltschnig
Copy link
Member

One point of Poco::Nullable and Poco::Optional was to avoid heap allocations, so Poco::Nullable should be implemented with std::optional as well.

matejk added a commit that referenced this issue Sep 18, 2024
@matejk
enh(Nullable, Optional): reimplement using std::optional (#4502)
cd6d287
@matejk matejk moved this to In Progress in 1.14 Sep 18, 2024
@matejk matejk mentioned this issue Sep 18, 2024
Merged
matejk added a commit that referenced this issue Sep 25, 2024
@matejk
enh(Nullable, Optional): reimplement using std::optional (#4502)
e55bb70
@github-project-automation github-project-automation bot moved this from In Progress to Done in 1.14 Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejk matejk

Labels
enhancement
Projects
1.14
Status: Done
Milestone
Release 1.14.0
Development

Successfully merging a pull request may close this issue.

enh(Nullable, Optional): reimplement using std::optional (#4502) pocoproject/poco
3 participants
@obiltschnig @matejk @aleks-f