Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poco::icompare(str, pos, ptr) out of bounds error if pos > str.size() #4866

Closed
obiltschnig opened this issue Feb 8, 2025 · 0 comments
Closed

Poco::icompare(str, pos, ptr) out of bounds error if pos > str.size() #4866

obiltschnig opened this issue Feb 8, 2025 · 0 comments
Assignees
@obiltschnig
Labels
bug fixed
Milestone
Release 1.14.1

Comments

@obiltschnig
Copy link
Member

obiltschnig commented Feb 8, 2025 •
edited
Loading

The implementation evaluates str.size() - pos without checking whether pos is < str.size() first, which may lead to an unsigned underflow followed by an out of bounds read.
@obiltschnig obiltschnig added the bug label Feb 8, 2025
@obiltschnig obiltschnig added this to the Release 1.14.1 milestone Feb 8, 2025
@obiltschnig obiltschnig self-assigned this Feb 8, 2025
@obiltschnig obiltschnig added this to 1.14 Feb 8, 2025
obiltschnig added a commit that referenced this issue Feb 8, 2025
@obiltschnig
fix(Foundation): Poco::icompare(str, pos, ptr) out of bounds error if…
4b55efd 
… pos > str.size() #4866
matejk pushed a commit that referenced this issue Feb 10, 2025
@obiltschnig @matejk
fix(Foundation): Poco::icompare(str, pos, ptr) out of bounds error if…
0ec643a 
… pos > str.size() #4866
@matejk matejk moved this to Done in 1.14 Feb 10, 2025
@matejk matejk closed this as completed Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obiltschnig obiltschnig

Labels
bug fixed
Projects
1.14
Status: Done
Milestone
Release 1.14.1
Development

No branches or pull requests
2 participants
@obiltschnig @matejk