Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using Poco::FileStream to wrap arbitrary file handles/descriptors as C++ streams #4424

Merged
merged 6 commits into from
May 8, 2024

Conversation

matejk
Copy link
Contributor

@matejk matejk commented Jan 29, 2024

Contains PR #3444 rebased on latest devel.

  • Allow opening a file descriptor/HANDLE as C++ stream.

  • FileStream: treat read from closed pipe as EOF.

  • chore(Filestream): conde style (naming)

Copy link
Member

@aleks-f aleks-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a testcase should be added.
this should be released in 1.14 - it changes the interface, so it is more appropriate to introduce it in major release

@matejk matejk force-pushed the file-stream-handle-merge branch 2 times, most recently from 931b122 to f424e62 Compare February 1, 2024 12:45
@matejk matejk deleted the branch main April 15, 2024 11:20
@matejk matejk closed this Apr 15, 2024
@matejk matejk reopened this Apr 22, 2024
@matejk matejk changed the base branch from devel to main April 22, 2024 06:58
…rs as C++ streams (#3444).

* Allow opening a file descriptor/HANDLE as C++ stream.

* FileStream: treat read from closed pipe as EOF.

* chore(Filestream): conde style (naming)

Co-Authored-By: Alex Fabijanic <[email protected]>
Co-Authored-By: Matej Kenda <[email protected]>
@matejk matejk force-pushed the file-stream-handle-merge branch from f424e62 to 59507e4 Compare May 7, 2024 09:45
@matejk matejk force-pushed the file-stream-handle-merge branch 2 times, most recently from 057448a to e4ec513 Compare May 7, 2024 13:39
@matejk matejk force-pushed the file-stream-handle-merge branch from e4ec513 to d7613d9 Compare May 8, 2024 08:01
@matejk matejk merged commit 065f9a0 into main May 8, 2024
42 checks passed
@matejk matejk deleted the file-stream-handle-merge branch May 8, 2024 10:57
@matejk matejk added the fixed label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants