Updated CMake to also include the generated pocomessage.rc File #4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
For consistency, this should be done in the |
|
Proper fix in ff26c8e |
|
@obiltschnig i was unsure what is the best place for this but looks good for me also to put it into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the
pocomessage.rcin the CMakeLists. Currently it is missing and thats leads to the issue that thePocoFoundation.dlldoes not contains the Message Format for the Eventlog Channel in Windows. So the Eventviewer will show a warning about the missing Information.I'm not the CMake Expert so i tried my best to solve it. If there is a better way then please let me know :).
At the moment i first need to create the File as an empty one because the
custom_commandis first called during the Build. So when runningcmake ..it is unable to find the file because it is not there.This will solve #3304