Skip to content

Commit

Permalink
[llvm-rc] Support joined or separate spelling for /fo flag
Browse files Browse the repository at this point in the history
CMake invokes rc using the joined spelling which appears to be supported
by Microsoft's rc implementation, so we should support it as well.

Differential Revision: https://reviews.llvm.org/D54191

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@346470 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
petrhosek committed Nov 9, 2018
1 parent c36c93b commit b9dd8a3
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
Empty file.
4 changes: 4 additions & 0 deletions test/tools/llvm-rc/flags.test
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
; RUN: llvm-rc /dry-run /FO %t %p/Inputs/empty.rc 2>&1 | FileCheck %s --allow-empty --check-prefix=FO
; RUN: llvm-rc /dry-run /FO%t %p/Inputs/empty.rc 2>&1 | FileCheck %s --allow-empty --check-prefix=FO

; FO-NOT: Exactly one input file should be provided.
2 changes: 1 addition & 1 deletion tools/llvm-rc/Opts.td
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ include "llvm/Option/OptParser.td"
// These options seem to be important for the tool
// and should be implemented.

def FILEOUT : Separate<[ "/", "-" ], "FO">,
def FILEOUT : JoinedOrSeparate<[ "/", "-" ], "FO">,
HelpText<"Change the output file location.">;

def DEFINE : Separate<[ "/", "-" ], "D">,
Expand Down

0 comments on commit b9dd8a3

Please sign in to comment.