Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sqlalchemy v2 #33

Merged
merged 4 commits into from
Aug 5, 2023
Merged

Support sqlalchemy v2 #33

merged 4 commits into from
Aug 5, 2023

Conversation

podhmo
Copy link
Owner

@podhmo podhmo commented May 30, 2023

@podhmo podhmo changed the title Support v2 Support sqlalchemy v2 May 30, 2023
podhmo
podhmo commented May 30, 2023
View reviewed changes
alchemyjsonschema/__init__.py
@@ -446,7 +445,7 @@ def _build_properties(
elif action == FOREIGNKEY: # ColumnProperty
for c in prop.columns:
sub = {}
if type(c.type) != VisitableType:
if type(c.type) != Visitable:
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is main diff

@podhmo podhmo merged commit b0f64e5 into master Aug 5, 2023
@podhmo podhmo deleted the support-v2 branch August 5, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support sqlalchemy >=2.0
1 participant
@podhmo