Fix crash when diffing LocalizedStringKey with FormatStyle #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will merge on green. Thanks for the partial fix! If you end up tackling any of the other edge cases we'd happily accept more PRs for them. We'd also accept test cases with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for #97. This fix covers the cases where an interpolation was appended using
appendInterpolation(_:format:)but does not cover the other cases mentioned in the issue.I attempted to fix the others as well and was able to unwrap a
(Date, Text.DateStyle), but there doesn't seem to be a publicly-accessible way to use the DateStyle to format the date. Here is a gist that demonstrates unwrapping the DateStyle:https://gist.github.com/daltonclaybrook/5491f296d9d5806dd31f4d777aea347f