Extend DependencyValues to provide features an instance of NotificationCenter they can observe.
#217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onCenter they can observe.
|
Hi @kielgillard, this has come up before (#203), and we don't feel that a Notification Center dependency is really needed. You can already freely post notifications in tests, and so they seem testable already. I'm going to close this for now, but feel free to open a discussion if there is something we are missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the example of how access to
TimeZonewas lifted intoDependencyValues.Slack thread: https://pointfreecommunity.slack.com/archives/C04L2D0MNJH/p1716871191834439