Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build of unit tests on Xcode 16 #330

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

pyrtsa
Copy link
Contributor

@pyrtsa pyrtsa commented Jan 14, 2025

The unit test file TestTraitTests.swift failed to build on Xcode 16:

'sleep(for:tolerance:clock:)' is only available in iOS 16.0 or newer

'milliseconds' is only available in iOS 16.0 or newer

Adding the appropriate @available markers fixes the build.

Copy link
Member

@mbrandonw mbrandonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pyrtsa, good catch! Thanks for that. Looks like we only run tests on macOS currently on CI.

@mbrandonw mbrandonw merged commit 565a7be into pointfreeco:main Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants