Swift 5 #51
Merged
Swift 5 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dang. Linux-only compiler bug: https://bugs.swift.org/browse/SR-10168 I think we can "fix" by un-nesting types that are in generic contexts, like: https://github.com/pointfreeco/swift-html/blob/master/Sources/Html/Attributes.swift#L404-L409 Not great...but otherwise we're kinda blocked. |
mbrandonw
reviewed
Mar 26, 2019
| @@ -1,6 +1,6 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2018 Brandon Williams | |||
| Copyright (c) 2019 Point-Free, Inc. | |||
There was a problem hiding this comment.
lol! i copied from an updated repo.
mbrandonw
approved these changes
Mar 26, 2019
|
Just to let know that the bug https://bugs.swift.org/browse/SR-10168 seems to be gone in Swift 5.1.1 on Linux 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Swift 5-ready release!