Add withErrorReporting

[stephencelis]

It's common to write the following boilerplate when working with code that can throw errors:

do {
  try work()
} catch {
  reportIssue(error)
}

Let's extract this pattern to a helper that can save at least some boilerplate:

withErrorReporting {
  try work()
}

Or even make it a 1-liner in some cases:

withErrorReporting(catching: work)

[lukeredpath]

Would you be willing to accepted a PR that adds an overload of this helper that rethrows rather than returns an optional? This can be helpful in situations where you are using async let, e.g.:

async let first = withErrorReporting("First") { try await first() }
async let second = withErrorReporting("Second") { try await second() }

If you want the overall function to still rethrow, having withErrorReporting swallow the error isn't that helpful.

[stephencelis]

@lukeredpath As long as there aren't overload issues that sounds like a good idea to us!

[lukeredpath]

I've been trying this out locally in my project and unfortunately using the same function name does seem to cause some overload issues. I'm not sure if its possible to resolve it, for now I've been using my own helper with a different name:

public func withRethrowingErrorReporting<R>(
    _ message: @autoclosure () -> String? = nil,
    to reporters: [any IssueReporter]? = nil,
    fileID: StaticString = #fileID,
    filePath: StaticString = #filePath,
    line: UInt = #line,
    column: UInt = #column,
    catching body: () async throws -> sending R
) async rethrows -> R {
    func performOperation() async throws -> R {
        do {
            return try await body()
        } catch {
            reportIssue(error, message(), fileID: fileID, filePath: filePath, line: line, column: column)
            throw error
        }
    }
    if let reporters {
        return try await withIssueReporters(reporters) {
            try await performOperation()
        }
    } else {
        return try await performOperation()
    }
}

I wonder, if this was part of the library, the versions that do not throw could be marked as @_disfavoredOverload.