Add isFailOnNewRecording for automatic recording #423
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I work on Screenshotbot, which is a screenshotbot/snapshot testing service, which automates all of the recording workflow. I'm also the original author of https://github.com/facebook/screenshot-tests-for-android, and previously built something very similar to Screenshotbot at Facebook.
With Screenshotbot, we would want to move the recording flow to CI. So developers shouldn't have to manually record screenshots. They should make the changes, push to CI/open a pull request, and the CI would automatically comment on the PR with whatever changes happened, (or if it's already merged, then sends a Jira/Asana/Github Issue task to the author).
But this requires that the tests don't fail when the snapshots change (because a screenshot change in this flow isn't a failure, it's just something that we send tasks for). And that's the feature I'm adding in this PR. It's a relatively straightforward change, but let me know if you need more information from me.