Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(games): use regional_support and national_support #314

Merged
merged 2 commits into from
Dec 28, 2018

Conversation

robinjoseph08
Copy link
Member

@robinjoseph08 robinjoseph08 commented Dec 25, 2018

°₊·ˈ∗(( ॣ>̶᷇ᗢ<̶᷆ ॣ))∗ˈ‧

  • instead of relying on NATIONAL_ONLY_GAMES, rely on db value of regional_support
    • i also made the db have regional_support = true for xy, oras, sumo, and usum so we'll support regional gen 7 dexes as well
  • rely on national_support to potentially not allow national dexes for a game. this isnt used now, but will be for lets go
  • the default value for "new dex" is always the latest game
  • change all references to specific games (e.g. the word alolan in various places)
  • fixes Editing dex's available Pokemon doesn't update until page is refreshed #311

Copy link
Member

@ami ami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok a couple things.

(1) SOMEtimes... not always.. when you go to a dex, the setting/unsetting of catches doesn't work. like the count on the top goes up, but the box doesn't turn yellow. so you'd think it's just a style thing, but also when you try to unclick it it also doesnt un-mark it. unfortunately i didn't figure out a great way to reliably reproduce it and also idk if that is due to this branch, or api changes, or if it's an issue in prod as well. haha. but here's a video:
https://imgur.com/a/hF0Jkwg

(2) ran into #311 -- since you're here, is it easy to fix that?

lgtm functionality wise other than that!

@ami ami assigned robinjoseph08 and unassigned ami Dec 25, 2018
@robinjoseph08
Copy link
Member Author

nice catch! fun fact, it was actually the same issue so fixing one fixed the other lol

@robinjoseph08 robinjoseph08 assigned ami and unassigned robinjoseph08 Dec 26, 2018
Copy link
Member

@ami ami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ami ami assigned robinjoseph08 and unassigned ami Dec 28, 2018
@robinjoseph08 robinjoseph08 merged commit 2ec1980 into master Dec 28, 2018
@robinjoseph08 robinjoseph08 deleted the national-support branch December 28, 2018 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing dex's available Pokemon doesn't update until page is refreshed
2 participants