Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Off-chain] fix: duplicate log fields #1040

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

bryanchriswhite
Copy link
Contributor

Summary

Construct a new logger instance for each session during settlement to avoid field duplication.

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added bug Something isn't working off-chain Off-chain business logic labels Jan 23, 2025
@bryanchriswhite bryanchriswhite self-assigned this Jan 23, 2025
@bryanchriswhite bryanchriswhite merged commit 7784a5b into main Jan 24, 2025
12 checks passed
@bryanchriswhite bryanchriswhite deleted the fix/log/off-chain branch January 24, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working off-chain Off-chain business logic
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants