-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Load Testing] gherkin/go implementation of test plan #1 #432
Conversation
Co-authored-by: Redouane Lakrache <[email protected]>
Co-authored-by: Bryan White <[email protected]>
…roof-integration * pokt/feat/proof-validation: chore: Add godoc comments chore: Update keeper query clients in-code documentation chore: Address review change requests [PubKeyClient] Implement PubKeyClient for on/off-chain usage (#413)
… test/proof-integration
…roof-integration * pokt/feat/proof-validation: fix: test error msg assertion
(cherry picked from commit eab6d984e65a9a07014c9a9839e7b55d125147a1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bryanchriswhite I stopped reviewing at ~ line 800 in load-testing/tests/relays_stress_helpers_test.go
but getting close.
Overall:
- I understand your bias towards "DO Repeat Yourself" and aligned with the approach.
- I think there's an opportunity to improve some var naming by making it more explicit so please take that into consideration as you go through my comments and/or do a self review.
- This PR was pretty big, so if there's a comment that you believe is non-relevant, bias to just resolving it without an explanation than trying to figure it out.
Overall, it's really work through. Undoubted.
I'll pick this up again once all the comments are tended to.
* pokt/main: [Code Health] chore: cleanup localnet testutils (#515) Zero retryLimit Support in ReplayClient (#442) [LocalNet] Add infrastructure to run LLM inference (#508) [LocalNet] Documentation for MVT/LocalNet (#488) [GATEWAY] Makefile target added to send relays to grove gateway (#487) Update README [CI] Add GATEWAY_URL envar for e2e tests (#506) [Tooling] Add gateway stake/unstake/ logs (#503)
Co-authored-by: Daniel Olshansky <[email protected]>
@Olshansk I think I covered everything except for a few comments: I think it's safe to re-review already. |
// blocksToMaxAmountIncrementEnd returns the number of blocks that will have | ||
// elapsed when one increment duration **after** the maxActorCount for the given | ||
// actor has been committed. | ||
func (plan *actorLoadTestIncrementPlan) blocksToMaxAmountIncrementEnd() int64 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@red-0ne 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more nits/asks, but otherwise g2g!
// Set content type to application/json | ||
req.Header.Set("Content-Type", "application/json") | ||
|
||
// Create an HTTP client and send the request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Understood, but going to use this as an opportunity to call out that we have to get better of reusing (updating / refactoring) each other's helpers rather than creating new ones every time.
Co-authored-by: Daniel Olshansky <[email protected]>
* pokt/main: [CI] Release artifacts job: binaries and containers (#523)
* pokt/main: A couple comment improvements Update google drive video to youtube video
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* pokt/main: [Documentation] Improve RelayMiner staking related documentation (#524)
🚨 Do not delete this branch until #521 has changed its base to |
Co-authored-by: Redouane Lakrache <[email protected]> Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: h5law <[email protected]> Co-authored-by: Dmitry K <[email protected]>
Summary
Implementing load test plan #1 using gherkin and go tests.
How to run:
gateways
andrelayminers
inlocalnet_config.yaml
(max number is 3 for each)relays_stress.feature
to match the testing plan to executeRun the test with the following command:
Issue
Type of change
Select one or more:
Testing
make go_develop_and_test
make test_e2e
devnet-test-e2e
label to the PR. THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.make docusaurus_start
Sanity Checklist