-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Redelegation] fix: EventRedelegation unmarshaling failure #435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! 👌
IIRC correctly, when we were discussing this, we couldn't come up with a great reason not to export cometTxEvent
. Otherwise this LGTM. 💪
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. If you just created a pull request, you might need to push another commit to produce a container image DevNet can utilize to spin up infrastructure. You can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Short and sweet nice changes :)
Co-authored-by: Dmitry K <[email protected]>
Summary
Unmarshalling transaction results logic in the delegation client is outdated, making the
RelayMiner
to panic when listening for these events.This PR uses
tx.UnmarshalTxResult
fromtxClient
to unmarshal the transaction.Issue
When the
RelayMiner
is running and observingEventRedelegation
s by listening toapplication
transactions, if a stake application occurs, the client tries to unmarshal it with a "pre-migration" code, causing theRelayMiner
to panicType of change
Select one or more:
Testing
make go_develop_and_test
make test_e2e
devnet-test-e2e
label to the PR. THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.make docusaurus_start
Sanity Checklist