[LocalNet] Add option to turn on/off delve #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okdas
added
infra
red-0ne
approved these changes
Apr 18, 2024
|
@Olshansk I'm going to merge it, please lmk if you have any feedback. :) |
bryanchriswhite
added a commit
that referenced
this pull request
Apr 24, 2024
…ment * pokt/main: [Config] feat: Simplify relay miner config (#477) [Testing] Add application staking with Makefile targets for app and gateways (#481) [LocalNet] Add option to turn on/off delve (#485) [SDK] Client TLS Support (#441) [TODOs] Add todos for future smt optimizations (#423) [Metrics] feat: Initial on-chain metrics implementation (#449) [Tooling] Add application stake/unstake/delegate logs (#482) [SMT] Updated smt release from v0.9.2 -> v0.10.2 (#472)
okdas
added a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows to turn delve on and off using
localnet_config.yaml.The related changes to helm charts were added in this PR - new functionality is optional and turned off by default, so I felt confident to merge.
Type of change
Select one or more:
Testing
Documentation changes (only if making doc changes)
make docusaurus_start; only needed if you make doc changesLocal Testing (only if making code changes)
make go_develop_and_testmake test_e2ePR Testing (only if making code changes)
devnet-test-e2elabel to the PR.make trigger_ciif you want to re-trigger tests without any code changesSanity Checklist