[Code Health] refactor: rename ApplicationTransfer msgs

e2e/tests/stake_app_transfer.feature

@@ -0,0 +1,21 @@
+Feature: App Stake Transfer Namespace
+
+    Scenario: User can transfer Application stake to non-existing application address
+        Given the user has the pocketd binary installed
+	# Unstake the applications in case they're already staked.
+        And this test ensures the "application" for account "app2" is not staked
+        And this test ensures the "application" for account "app3" is not staked
+        # Stake with 1 uPOKT more than the current stake used in genesis to make
+        # the transaction succeed.
+        And the account "app2" has a balance greater than "1000070" uPOKT
+        And an account exists for "app3"
+        And the user successfully stakes a "application" with "1000070" uPOKT for "anvil" service from the account "app2"
+        When the user transfers the "application" stake from account "app2" to account "app3"
+        Then the user should be able to see standard output containing "txhash:"
+        And the user should be able to see standard output containing "code: 0"
+        And the pocketd binary should exit without error
+        And the user should wait for the "application" module "TransferApplication" message to be submitted
+        And the "application" for account "app3" is staked with "1000070" uPOKT
+        And the account balance of "app3" should be "0" uPOKT "less" than before
+        And the user verifies the "application" for account "app2" is not staked
+        And the account balance of "app2" should be "0" uPOKT "more" than before

e2e/tests/stake_app_transfer_steps_test.go

@@ -0,0 +1,51 @@
+//go:build e2e
+
+package e2e
+
+import (
+	"github.com/stretchr/testify/require"
+)
+
+func (s *suite) TheUserSuccessfullyStakesAWithUpoktForServiceFromTheAccount(actorType string, amount int64, serviceId, accName string) {
+	s.TheUserStakesAWithUpoktForServiceFromTheAccount(actorType, amount, serviceId, accName)
+	s.TheUserShouldBeAbleToSeeStandardOutputContaining("txhash:")
+	s.TheUserShouldBeAbleToSeeStandardOutputContaining("code: 0")
+	s.ThePocketdBinaryShouldExitWithoutError()
+	s.TheUserShouldWaitForTheModuleMessageToBeSubmitted("application", "StakeApplication")
+	s.TheForAccountIsStakedWithUpokt(actorType, accName, amount)
+	s.TheAccountBalanceOfShouldBeUpoktThanBefore(accName, amount, "less")
+}
+
+func (s *suite) TheUserTransfersTheStakeFromAccountToAccount(actorType, fromAccName, toAccName string) {
+	fromAddr, fromAddrIsFound := accNameToAddrMap[fromAccName]
+	require.Truef(s, fromAddrIsFound, "account name %s not found in accNameToAddrMap", fromAccName)
+
+	toAddr, toAddrIsFound := accNameToAddrMap[toAccName]
+	require.Truef(s, toAddrIsFound, "account name %s not found in accNameToAddrMap", toAccName)
+
+	args := []string{
+		"tx",
+		actorType,
+		"transfer",
+		fromAddr,
+		toAddr,
+		"--from",
+		fromAccName,
+		keyRingFlag,
+		chainIdFlag,
+		"-y",
+	}
+	res, err := s.pocketd.RunCommandOnHost("", args...)
+	require.NoError(s, err)
+
+	s.pocketd.result = res
+}
+
+// This helper ensures that the actor is unstaked if it was staked when this step ran.
+func (s *suite) ThisTestEnsuresTheForAccountIsNotStaked(actorType, accName string) {
+	if _, ok := s.getStakedAmount(actorType, accName); ok {
+		s.TheUserUnstakesAFromTheAccount(actorType, accName)
+		s.TheUserShouldBeAbleToSeeStandardOutputContaining("txhash:")
+		s.TheUserShouldBeAbleToSeeStandardOutputContaining("code: 0")
+	}
+}

proto/poktroll/application/tx.proto

@@ -1,4 +1,5 @@
 syntax = "proto3";
+
 package poktroll.application;
 
 option go_package = "github.com/pokt-network/poktroll/x/application/types";
@@ -9,27 +10,27 @@ import "cosmos_proto/cosmos.proto";
 import "cosmos/base/v1beta1/coin.proto";
 import "cosmos/msg/v1/msg.proto";
 import "gogoproto/gogo.proto";
-
+import "poktroll/application/types.proto";
 import "poktroll/application/params.proto";
 import "poktroll/shared/service.proto";
 
-
 // Msg defines the Msg service.
 service Msg {
   option (cosmos.msg.v1.service) = true;
 
   // UpdateParams defines a (governance) operation for updating the module
   // parameters. The authority defaults to the x/gov module account.
-  rpc UpdateParams          (MsgUpdateParams         ) returns (MsgUpdateParamsResponse         );
-  rpc StakeApplication      (MsgStakeApplication     ) returns (MsgStakeApplicationResponse     );
-  rpc UnstakeApplication    (MsgUnstakeApplication   ) returns (MsgUnstakeApplicationResponse   );
-  rpc DelegateToGateway     (MsgDelegateToGateway    ) returns (MsgDelegateToGatewayResponse    );
-  rpc UndelegateFromGateway (MsgUndelegateFromGateway) returns (MsgUndelegateFromGatewayResponse);
+  rpc UpdateParams             (MsgUpdateParams) returns (MsgUpdateParamsResponse);
+  rpc StakeApplication         (MsgStakeApplication) returns (MsgStakeApplicationResponse);
+  rpc UnstakeApplication       (MsgUnstakeApplication) returns (MsgUnstakeApplicationResponse);
+  rpc DelegateToGateway        (MsgDelegateToGateway) returns (MsgDelegateToGatewayResponse);
+  rpc UndelegateFromGateway    (MsgUndelegateFromGateway) returns (MsgUndelegateFromGatewayResponse);
+  rpc TransferApplication      (MsgTransferApplication) returns (MsgTransferApplicationResponse);
 }
 // MsgUpdateParams is the Msg/UpdateParams request type.
 message MsgUpdateParams {
   option (cosmos.msg.v1.signer) = "authority";
-  option (amino.name) = "poktroll/x/application/MsgUpdateParams";
+  option           (amino.name) = "poktroll/x/application/MsgUpdateParams";
 
   // authority is the address that controls the module (defaults to x/gov unless overwritten).
   string authority = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"];
@@ -49,10 +50,12 @@ message MsgUpdateParamsResponse {}
 
 message MsgStakeApplication {
   option (cosmos.msg.v1.signer) = "address";
-
-  string address = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"]; // The Bech32 address of the application.
-  cosmos.base.v1beta1.Coin stake = 2; // The total amount of uPOKT the application has staked. Must be ≥ to the current amount that the application has staked (if any)
+  string                                   address = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"]; // The Bech32 address of the application.
+  cosmos.base.v1beta1.Coin                 stake = 2; // The total amount of uPOKT the application has staked. Must be ≥ to the current amount that the application has staked (if any)
   repeated poktroll.shared.ApplicationServiceConfig services = 3; // The list of services this application is staked to request service for
+  // TODO_POST_MAINNET_CONSIDERATION: Consdier allowing appplications to delegate
+  // to gateways at time of staking for a better developer experience.
+  // repeated string gateway_addresss
 }
 
 message MsgStakeApplicationResponse {}
@@ -68,7 +71,6 @@ message MsgDelegateToGateway {
   option (cosmos.msg.v1.signer) = "app_address"; // https://docs.cosmos.network/main/build/building-modules/messages-and-queries
   string app_address = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"]; // The Bech32 address of the application.
   string gateway_address = 2 [(cosmos_proto.scalar) = "cosmos.AddressString"]; // The Bech32 address of the gateway the application wants to delegate to.
-
 }
 
 message MsgDelegateToGatewayResponse {}
@@ -81,3 +83,13 @@ message MsgUndelegateFromGateway {
 
 message MsgUndelegateFromGatewayResponse {}
 
+message MsgTransferApplication {
+  option (cosmos.msg.v1.signer) = "source_address";
+  string source_address = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"];
+  string destination_address = 2 [(cosmos_proto.scalar) = "cosmos.AddressString"];
+}
+
+message MsgTransferApplicationResponse {
+  poktroll.application.Application application = 1;
+}
+

x/application/keeper/msg_server_transfer_application_stake.go

@@ -0,0 +1,68 @@
+package keeper
+
+import (
+	"context"
+	"fmt"
+
+	"github.com/pokt-network/poktroll/telemetry"
+	"github.com/pokt-network/poktroll/x/application/types"
+)
+
+// TransferApplication transfers the stake (held in escrow in the application
+// module account) from a source to a (new) destination application account .
+func (k msgServer) TransferApplication(ctx context.Context, msg *types.MsgTransferApplication) (*types.MsgTransferApplicationResponse, error) {
+	isSuccessful := false
+	defer telemetry.EventSuccessCounter(
+		"transfer_application_stake",
+		telemetry.DefaultCounterFn,
+		func() bool { return isSuccessful },
+	)
+
+	logger := k.Logger().With("method", "TransferApplication")
+
+	if err := msg.ValidateBasic(); err != nil {
+		return nil, err
+	}
+
+	// Ensure destination application does not already exist.
+	_, isDstFound := k.GetApplication(ctx, msg.GetDestinationAddress())
+	if isDstFound {
+		return nil, types.ErrAppDuplicateAddress.Wrapf("destination application (%q) exists", msg.GetDestinationAddress())
+	}
+
+	// Ensure source application exists.
+	srcApp, isAppFound := k.GetApplication(ctx, msg.GetSourceAddress())
+	if !isAppFound {
+		return nil, types.ErrAppNotFound.Wrapf("source application %q not found", msg.GetSourceAddress())
+	}
+
+	// Ensure source application is not already unbonding.
+	// TODO_TEST: Add E2E coverage to assert that an unbonding app cannot be transferred.
+	if srcApp.IsUnbonding() {
+		return nil, types.ErrAppIsUnstaking.Wrapf("cannot transfer stake of unbonding source application %q", msg.GetSourceAddress())
+	}
+
+	// Create a new application derived from the source application.
+	dstApp := srcApp
+	dstApp.Address = msg.GetDestinationAddress()
+
+	// TODO_NEXT(#789): Reconcile app unbonding logic with the new transfer stake logic.
+	// I.e., the source should not immediately be transferred.
+
+	// TODO_TEST: add E2E coverage to assert #DelegateeGatewayAddresses and #PendingUndelegations
+	// are present and correct on the dstApp application.
+
+	// Update the dstApp in the store
+	k.SetApplication(ctx, dstApp)
+	logger.Info(fmt.Sprintf("Successfully transferred application stake from (%s) to (%s)", srcApp.Address, dstApp.Address))
+
+	// Remove the transferred app from the store
+	k.RemoveApplication(ctx, srcApp.GetAddress())
+	logger.Info(fmt.Sprintf("Successfully removed the application: %+v", srcApp))
+
+	isSuccessful = true
+
+	return &types.MsgTransferApplicationResponse{
+		Application: &srcApp,
+	}, nil
+}