Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Container image] Change base image for release #829

Merged
merged 2 commits into from
Sep 17, 2024
Merged

[Container image] Change base image for release #829

merged 2 commits into from
Sep 17, 2024

Conversation

okdas
Copy link
Member

@okdas okdas commented Sep 17, 2024 •
edited
Loading

Summary

Changes the base image from alpine to debian.
Potentially unblocks heighliner.

Issue

Removes the need for gcompat - glibc compatibility layer for musl.

Type of change

Select one or more from the following:

Testing

Executed build targets, built image, checked poktrolld.

Steps to reproduce:

make proto_regen
make cosmovisor_cross_compile
make ignite_release
make ignite_release_extract_binaries
docker build --no-cache --progress=plain --platform linux/amd64,linux/arm64 -t poktrolldebian -f Dockerfile.release .
docker run -it --rm --entrypoint poktrolld poktrolldebian

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@okdas okdas added the tooling Tooling - CLI, scripts, helpers, off-chain, etc... label Sep 17, 2024
@okdas okdas added this to the Shannon Beta TestNet Launch milestone Sep 17, 2024
@okdas okdas self-assigned this Sep 17, 2024
@okdas okdas marked this pull request as ready for review September 17, 2024 20:23
@okdas okdas requested a review from Olshansk September 17, 2024 20:26
Olshansk
Olshansk approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes yes yes!

@okdas okdas merged commit 56f7052 into main Sep 17, 2024
10 checks passed
@Olshansk Olshansk deleted the alpine-to-debian branch September 17, 2024 21:32
bryanchriswhite added a commit that referenced this pull request Sep 19, 2024
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into issues/799/refactor/int…
d9e9c28 
…egration-app

* pokt/main:
  [Supplier] Initial slashing implementation (#795)
  [Container image] Change base image for release (#829)
  [Proof] Prevent proof submission when not required (#822)
bryanchriswhite added a commit that referenced this pull request Sep 19, 2024
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into issues/657/feat/app-sta…
dcac5d7 
…ke-transfer

* pokt/main:
  [Supplier] Initial slashing implementation (#795)
  [Container image] Change base image for release (#829)
  [Proof] Prevent proof submission when not required (#822)
bryanchriswhite added a commit that referenced this pull request Sep 19, 2024
@bryanchriswhite
Merge branch 'issues/657/feat/app-stake-transfer' into issues/657/ref…
5551d90 
…actor/transfer-msg_period-param

* issues/657/feat/app-stake-transfer:
  [Supplier] Initial slashing implementation (#795)
  [Container image] Change base image for release (#829)
  [Proof] Prevent proof submission when not required (#822)
bryanchriswhite added a commit that referenced this pull request Sep 19, 2024
@bryanchriswhite
Merge branch 'issues/657/refactor/transfer-msg_period-param' into iss…
decb8fd 
…ues/657/chore/app-transfer-period

* issues/657/refactor/transfer-msg_period-param:
  [Supplier] Initial slashing implementation (#795)
  [Container image] Change base image for release (#829)
  [Proof] Prevent proof submission when not required (#822)

# Conflicts:
#	app/app_config.go
bryanchriswhite added a commit that referenced this pull request Sep 19, 2024
@bryanchriswhite
Merge branch 'issues/799/e2e/idempotent-stake-supplier' into issues/7…
a2ee2c2 
…99/e2e/param-helpers

* issues/799/e2e/idempotent-stake-supplier:
  chore: add comment
  chore: sync shared module default params
  fix: failing E2E test
  [Supplier] Initial slashing implementation (#795)
  [Container image] Change base image for release (#829)
  [Proof] Prevent proof submission when not required (#822)
  chore: rename paramsAnyMap type to mitigate variable name shadowing
  [Tooling, Code Health] refactor: split Makefile into multiple files (#816)
  [Tooling] fix and add makefile targets (#814)
  [Docs] Add a debugging tip: using transaction hashes (#786)
bryanchriswhite added a commit that referenced this pull request Sep 19, 2024
@bryanchriswhite
Merge branch 'issues/799/e2e/param-helpers' into issues/799/feat/supp…
8546244 
…lier-stake-events

* issues/799/e2e/param-helpers:
  chore: review feedback improvements
  chore: add comment
  chore: sync shared module default params
  fix: failing E2E test
  [Supplier] Initial slashing implementation (#795)
  [Container image] Change base image for release (#829)
  [Proof] Prevent proof submission when not required (#822)
  chore: rename paramsAnyMap type to mitigate variable name shadowing
  [Tooling, Code Health] refactor: split Makefile into multiple files (#816)
  [Tooling] fix and add makefile targets (#814)
  [Docs] Add a debugging tip: using transaction hashes (#786)
bryanchriswhite added a commit that referenced this pull request Sep 19, 2024
@bryanchriswhite
Merge branch 'issues/799/feat/supplier-stake-events' into issues/799/…
dfb5c05 
…tests/params

* issues/799/feat/supplier-stake-events:
  chore: review feedback improvements
  chore: add comment
  chore: sync shared module default params
  fix: failing E2E test
  [Supplier] Initial slashing implementation (#795)
  [Container image] Change base image for release (#829)
  [Proof] Prevent proof submission when not required (#822)
  chore: rename paramsAnyMap type to mitigate variable name shadowing
  [Tooling, Code Health] refactor: split Makefile into multiple files (#816)
  [Tooling] fix and add makefile targets (#814)
  [Docs] Add a debugging tip: using transaction hashes (#786)
okdas added a commit that referenced this pull request Nov 14, 2024
@okdas
[Container image] Change base image for release (#829)
b287276 
## Summary

Changes the base image from alpine to debian.
Potentially unblocks `heighliner`. 

## Issue

Removes the need for `gcompat` - `glibc` compatibility layer for `musl`.

## Type of change

Select one or more from the following:

- [ ] New feature, functionality or library
- [ ] Consensus breaking; add the `consensus-breaking` label if so. See
#791 for details
- [ ] Bug fix
- [x] Code health or cleanup
- [ ] Documentation
- [ ] Other (specify)

## Testing

Executed build targets, built image, checked `poktrolld`.

Steps to reproduce:

```
make proto_regen
make cosmovisor_cross_compile
make ignite_release
make ignite_release_extract_binaries
docker build --no-cache --progress=plain --platform linux/amd64,linux/arm64 -t poktrolldebian -f Dockerfile.release .
docker run -it --rm --entrypoint poktrolld poktrolldebian
```


## Sanity Checklist

- [ ] I have tested my changes using the available tooling
- [ ] I have commented my code
- [ ] I have performed a self-review of my own code; both comments &
source code
- [ ] I create and reference any new tickets, if applicable
- [ ] I have left TODOs throughout the codebase, if applicable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Olshansk Olshansk Olshansk approved these changes

Assignees

@okdas okdas

Labels
tooling Tooling - CLI, scripts, helpers, off-chain, etc...
Projects
Shannon
Status: ✅ Done
Milestone
Shannon Beta TestNet Launch
Development

Successfully merging this pull request may close these issues.
2 participants
@okdas @Olshansk