feat: add SMT specific errors

bulk_test.go

@@ -82,7 +82,7 @@ func bulkOperations(t *testing.T, operations int, insert int, update int, delete
 			ki := r.Intn(len(kv))
 
 			err := smt.Delete(kv[ki].key)
-			if err != nil && err != simplemap.ErrKVStoreKeyNotFound {
+			if err != nil && err != ErrKeyNotFound {
 				t.Fatalf("error: %v", err)
 			}
 			kv[ki].val = defaultValue

errors.go

@@ -4,5 +4,9 @@ import (
 	"errors"
 )
 
-// ErrBadProof is returned when an invalid Merkle proof is supplied.
-var ErrBadProof = errors.New("bad proof")
+var (
+	// ErrBadProof is returned when an invalid Merkle proof is supplied.
+	ErrBadProof = errors.New("bad proof")
+	// ErrKeyNotFound is returned when a key is not found in the tree.
+	ErrKeyNotFound = errors.New("key not found")
+)

fuzz_test.go

@@ -68,7 +68,7 @@ func FuzzSMT_DetectUnexpectedFailures(f *testing.F) {
 				_, err := trie.Get(key())
 				if err != nil {
 					require.ErrorIsf(
-						t, err, simplemap.ErrKVStoreKeyNotFound,
+						t, err, ErrKeyNotFound,
 						"unknown error occurred while getting",
 					)
 				}
@@ -85,7 +85,7 @@ func FuzzSMT_DetectUnexpectedFailures(f *testing.F) {
 				err := trie.Delete(key())
 				if err != nil {
 					require.ErrorIsf(
-						t, err, simplemap.ErrKVStoreKeyNotFound,
+						t, err, ErrKeyNotFound,
 						"unknown error occurred while deleting",
 					)
 					continue
@@ -97,7 +97,7 @@ func FuzzSMT_DetectUnexpectedFailures(f *testing.F) {
 				_, err := trie.Prove(key())
 				if err != nil {
 					require.ErrorIsf(
-						t, err, simplemap.ErrKVStoreKeyNotFound,
+						t, err, ErrKeyNotFound,
 						"unknown error occurred while proving",
 					)
 				}

smst_utils_test.go

@@ -7,7 +7,6 @@ import (
 	"fmt"
 
 	"github.com/pokt-network/smt/kvstore"
-	"github.com/pokt-network/smt/kvstore/simplemap"
 )
 
 // SMSTWithStorage wraps an SMST with a mapping of value hashes to values with
@@ -49,7 +48,7 @@ func (smst *SMSTWithStorage) GetValueSum(key []byte) ([]byte, uint64, error) {
 	}
 	value, err := smst.preimages.Get(valueHash)
 	if err != nil {
-		if errors.Is(err, simplemap.ErrKVStoreKeyNotFound) {
+		if errors.Is(err, ErrKeyNotFound) {
 			// If key isn't found, return default value and sum
 			return defaultValue, 0, nil
 		}

smt.go

@@ -5,7 +5,6 @@ import (
 	"hash"
 
 	"github.com/pokt-network/smt/kvstore"
-	"github.com/pokt-network/smt/kvstore/simplemap"
 )
 
 var (
@@ -247,11 +246,11 @@ func (smt *SMT) delete(node trieNode, depth int, path []byte, orphans *orphanNod
 	}
 
 	if node == nil {
-		return node, simplemap.ErrKVStoreKeyNotFound
+		return node, ErrKeyNotFound
 	}
 	if leaf, ok := node.(*leafNode); ok {
 		if !bytes.Equal(path, leaf.path) {
-			return node, simplemap.ErrKVStoreKeyNotFound
+			return node, ErrKeyNotFound
 		}
 		smt.addOrphan(orphans, node)
 		return nil, nil
@@ -261,7 +260,7 @@ func (smt *SMT) delete(node trieNode, depth int, path []byte, orphans *orphanNod
 
 	if ext, ok := node.(*extensionNode); ok {
 		if _, match := ext.match(path, depth); !match {
-			return node, simplemap.ErrKVStoreKeyNotFound
+			return node, ErrKeyNotFound
 		}
 		ext.child, err = smt.delete(ext.child, depth+ext.length(), path, orphans)
 		if err != nil {

smt_utils_test.go

@@ -5,7 +5,6 @@ import (
 	"errors"
 
 	"github.com/pokt-network/smt/kvstore"
-	"github.com/pokt-network/smt/kvstore/simplemap"
 )
 
 // SMTWithStorage wraps an SMT with a mapping of value hashes to values
@@ -43,7 +42,7 @@ func (smt *SMTWithStorage) GetValue(key []byte) ([]byte, error) {
 	}
 	value, err := smt.preimages.Get(valueHash)
 	if err != nil {
-		if errors.Is(err, simplemap.ErrKVStoreKeyNotFound) {
+		if errors.Is(err, ErrKeyNotFound) {
 			// If key isn't found, return default value
 			value = defaultValue
 		} else {