Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update proofs.go #30

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Update proofs.go #30

merged 2 commits into from
Dec 6, 2023

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Dec 6, 2023

Screenshot 2023-12-05 at 5 59 24 PM

@Olshansk
Update proofs.go
d496d8c 
Update comment related to `ClosestsValueHash`
@reviewpad reviewpad bot added small Pull request is small waiting-for-review This PR is currently waiting to be reviewed labels Dec 6, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 6, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0278e35) 83.30% compared to head (ba30fb8) 83.30%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   83.30%   83.30%           
=======================================
  Files           8        8           
  Lines        1408     1408           
=======================================
  Hits         1173     1173           
  Misses        178      178           
  Partials       57       57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Olshansk Olshansk requested a review from h5law December 6, 2023 02:03
h5law
h5law approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@h5law h5law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice comment <3

@h5law h5law merged commit a14e995 into main Dec 6, 2023
7 checks passed
@h5law h5law deleted the Olshansk-patch-1 branch December 6, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h5law h5law h5law approved these changes

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review This PR is currently waiting to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Olshansk @h5law