-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT][WIP] Code cleanup & docs during audit process #40
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 83.15% 85.12% +1.97%
==========================================
Files 9 14 +5
Lines 1460 1526 +66
==========================================
+ Hits 1214 1299 +85
+ Misses 185 170 -15
+ Partials 61 57 -4 ☔ View full report in Codecov by Sentry. |
@h5law (not urgent) Wanted to make sure you get an email/notification w.r.t these changes that I'm making. It's just naming, comments, and code refactoring from the perspective of someone who didn't implement the code and is exploring it for the first time. The goal is to simply make it really easy for future readers of the code (who might not know how SMTs work) approach and contribute to it. |
…but struggling with parsing in smst_example_test.go
Summary
Human Summary
AI Summary
reviewpad:summary
Issue
Fixes #<issue_number>
[Explain the reasoning for the PR in 1-2 sentences. Consider adding a link or a screenshot.]
Type of change
Please mark the relevant option(s):
Testing
make test_all
make benchmark_{all | suite name}
Required Checklist
godoc
format comments see: tip.golang.org/doc/comment)If Applicable Checklist