Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT][WIP] Code cleanup & docs during audit process #40

Closed
wants to merge 24 commits into from
Closed

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Feb 8, 2024

Summary

Human Summary

AI Summary

reviewpad:summary

Issue

Fixes #<issue_number>

[Explain the reasoning for the PR in 1-2 sentences. Consider adding a link or a screenshot.]

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make test_all
  • Run all/relevant benchmarks (if optimising): make benchmark_{all | suite name}

Required Checklist

If Applicable Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated any relevant README(s)/documentation and left TODOs throughout the codebase
  • Add or update any relevant or supporting mermaid diagrams

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (8682379) 83.15% compared to head (03d85ea) 85.12%.

Files Patch % Lines
smt.go 93.58% 5 Missing and 5 partials ⚠️
kvstore/simplemap/simplemap.go 0.00% 4 Missing ⚠️
node_encoders.go 95.40% 2 Missing and 2 partials ⚠️
types.go 93.18% 3 Missing ⚠️
extension_node.go 97.50% 1 Missing and 1 partial ⚠️
lazy_node.go 0.00% 2 Missing ⚠️
smst.go 95.12% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   83.15%   85.12%   +1.97%     
==========================================
  Files           9       14       +5     
  Lines        1460     1526      +66     
==========================================
+ Hits         1214     1299      +85     
+ Misses        185      170      -15     
+ Partials       61       57       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Olshansk
Copy link
Member Author

@h5law (not urgent)

Wanted to make sure you get an email/notification w.r.t these changes that I'm making. It's just naming, comments, and code refactoring from the perspective of someone who didn't implement the code and is exploring it for the first time.

The goal is to simply make it really easy for future readers of the code (who might not know how SMTs work) approach and contribute to it.

…but struggling with parsing in smst_example_test.go
@Olshansk Olshansk closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants