-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Leaf Counter] Adding a cryptographically secure non-empty leaf counter #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish it would be possible to order the files of a PR to review but I finally got how non-empty leaf count is being added 😄
Left some change requests but look good overall.
Co-authored-by: Redouane Lakrache <[email protected]> Signed-off-by: Daniel Olshansky <[email protected]>
Co-authored-by: Redouane Lakrache <[email protected]> Signed-off-by: Daniel Olshansky <[email protected]>
Co-authored-by: Redouane Lakrache <[email protected]> Signed-off-by: Daniel Olshansky <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good left a few comments, some suggestions on how count could be computed as a *big.Int
instead which would result in variable digest lengths which would probably aid security.
Co-authored-by: h5law <[email protected]> Signed-off-by: Daniel Olshansky <[email protected]>
Co-authored-by: h5law <[email protected]> Signed-off-by: Daniel Olshansky <[email protected]>
Co-authored-by: h5law <[email protected]> Signed-off-by: Daniel Olshansky <[email protected]>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 81.31% 82.96% +1.65%
==========================================
Files 9 14 +5
Lines 1493 1691 +198
==========================================
+ Hits 1214 1403 +189
- Misses 215 225 +10
+ Partials 64 63 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to approve - left a few comments but going to unblock. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 👌
Co-authored-by: h5law <[email protected]> Signed-off-by: Daniel Olshansky <[email protected]>
Co-authored-by: h5law <[email protected]> Signed-off-by: Daniel Olshansky <[email protected]>
Summary
count
to get the number of non-empty leaf nodes in every sub-triesum
in its implementationIssue
Type of change
Please mark the relevant option(s):
Testing
make test_all
make benchmark_{all | suite name}
Required Checklist
godoc
format comments see: tip.golang.org/doc/comment)If Applicable Checklist