Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate str.explode #14605

Closed
stinodego opened this issue Feb 20, 2024 · 0 comments · Fixed by #16508
Closed

Deprecate str.explode #14605

stinodego opened this issue Feb 20, 2024 · 0 comments · Fixed by #16508
Assignees
@stinodego
Labels
A-dtype-string Area: string data type accepted Ready for implementation deprecation Add a deprecation warning to outdated functionality python Related to Python Polars rust Related to Rust Polars
Milestone
1.0.0

Comments

@stinodego
Copy link
Member

stinodego commented Feb 20, 2024 •
edited
Loading

Ref #12884 (comment)

We want to deprecate this method as it's very niche. It was included originally as it was easily implemented in a similar fashion to other explodes, but this is no longer true with the new string type.

First we should fix #14604. Then we can recommend users to replace their .str.explode() by .str.split("").explode().
@stinodego stinodego added python Related to Python Polars rust Related to Rust Polars accepted Ready for implementation deprecation Add a deprecation warning to outdated functionality labels Feb 20, 2024
@github-project-automation github-project-automation bot moved this to Ready in Backlog Feb 20, 2024
@stinodego stinodego self-assigned this Feb 20, 2024
@stinodego stinodego moved this from Ready to In progress in Backlog Feb 20, 2024
@stinodego stinodego moved this from In progress to Candidate in Backlog Feb 20, 2024
@stinodego stinodego removed their assignment Feb 20, 2024
@stinodego stinodego added blocked Cannot be worked on due to external dependencies, or significant new internal features needed first A-dtype-string Area: string data type labels Feb 20, 2024
@stinodego stinodego self-assigned this May 26, 2024
@stinodego stinodego mentioned this issue May 26, 2024
Merged
@stinodego stinodego moved this from Candidate to Blocked in Backlog May 26, 2024
@stinodego stinodego added this to the 1.0.0 milestone May 26, 2024
@stinodego stinodego moved this from Blocked to In progress in Backlog May 26, 2024
@stinodego stinodego moved this from In progress to Blocked in Backlog May 26, 2024
@stinodego stinodego moved this from Blocked to In progress in Backlog May 26, 2024
@stinodego stinodego removed the blocked Cannot be worked on due to external dependencies, or significant new internal features needed first label May 26, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Backlog May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stinodego stinodego

Labels
A-dtype-string Area: string data type accepted Ready for implementation deprecation Add a deprecation warning to outdated functionality python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

depr(python,rust!): Deprecate str.explode in favor of str.split("").explode() pola-rs/polars
1 participant
@stinodego