depr(python,rust!): Deprecate str.explode in favor of str.split("").explode()
#16508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
breaking rust
stinodego
changed the title
str.explodestr.explode in favor of str.split("").explode()
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16508 +/- ##
==========================================
- Coverage 81.53% 81.52% -0.02%
==========================================
Files 1410 1410
Lines 185061 184948 -113
Branches 2982 2984 +2
==========================================
- Hits 150885 150772 -113
Misses 33660 33660
Partials 516 516 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #16508 will degrade performances by 15.56%Comparing Summary
Benchmarks breakdown
|
stinodego
commented
May 27, 2024
Comment on lines
+2396
to
+2397
| split = self.split("") | ||
| return F.when(split.ne_missing([])).then(split).otherwise([""]).explode() |
There was a problem hiding this comment.
This replaces the existing functionality until it is removed completely.
ritchie46
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14605
It's a bit of an odd function that makes less sense now that our string representation no longer has offsets.
Users should use
str.split("").explode()instead.