Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitwise aggregations do not ignore nulls #19065

Closed
orlp opened this issue Oct 2, 2024 · 1 comment · Fixed by #19067
Closed

Bitwise aggregations do not ignore nulls #19065

orlp opened this issue Oct 2, 2024 · 1 comment · Fixed by #19067
Assignees
@orlp
Labels
accepted Ready for implementation bug Something isn't working P-high Priority: high

Comments

@orlp
Copy link
Collaborator

orlp commented Oct 2, 2024 •
edited
Loading

All aggregations should ignore missing values, currently the bitwise_(and/or/xor) aggregations do not:

>>> pl.Series([1, 2, None]).sum()
3
>>> pl.Series([1, 2, None]).bitwise_or()
shape: (1,)
Series: '' [i64]
[
        null
]
@orlp orlp added bug Something isn't working accepted Ready for implementation P-high Priority: high labels Oct 2, 2024
@github-project-automation github-project-automation bot moved this to Ready in Backlog Oct 2, 2024
@ritchie46
Copy link
Member

@coastalwhite can you take this one. (Once better)

@orlp orlp self-assigned this Oct 2, 2024
@orlp orlp mentioned this issue Oct 2, 2024
Merged
@github-project-automation github-project-automation bot moved this from Ready to Done in Backlog Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orlp orlp

Labels
accepted Ready for implementation bug Something isn't working P-high Priority: high
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Bitwise aggregations should ignore null values orlp/polars
2 participants
@orlp @ritchie46