Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bitwise aggregations should ignore null values #19067

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Oct 2, 2024

Fixes #19065.

Also fixes #19066.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 2, 2024
@orlp orlp changed the title fix: Bitwise aggregations should not ignore nulls fix: Bitwise aggregations should ignore null values Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 32.43243% with 50 lines in your changes missing coverage. Please review.

Project coverage is 79.77%. Comparing base (b1b322f) to head (d9f9d17).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-python/src/series/aggregation.rs 0.00% 27 Missing ⚠️
crates/polars-compute/src/bitwise/mod.rs 51.61% 15 Missing ⚠️
...olars-core/src/chunked_array/ops/bitwise_reduce.rs 50.00% 5 Missing ⚠️
py-polars/polars/series/series.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19067      +/-   ##
==========================================
+ Coverage   79.75%   79.77%   +0.02%     
==========================================
  Files        1531     1531              
  Lines      208547   208500      -47     
  Branches     2913     2913              
==========================================
+ Hits       166319   166333      +14     
+ Misses      41677    41616      -61     
  Partials      551      551              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp merged commit 463c436 into pola-rs:main Oct 2, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bitwise aggregations do not return scalar when called on Series Bitwise aggregations do not ignore nulls
2 participants