Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Rust examples in examples/ folder in CI #19186

Closed
nameexhaustion opened this issue Oct 11, 2024 · 2 comments · Fixed by #19430
Closed

Check Rust examples in examples/ folder in CI #19186

nameexhaustion opened this issue Oct 11, 2024 · 2 comments · Fixed by #19430
Assignees
@stinodego
Labels
accepted Ready for implementation ci Related to the continuous integration setup documentation Improvements or additions to documentation enhancement New feature or an improvement of an existing feature P-low Priority: low rust Related to Rust Polars

Comments

@nameexhaustion
Copy link
Collaborator

Description

Currently aren't checked, so we get issues e.g. #19129
@nameexhaustion nameexhaustion added documentation Improvements or additions to documentation rust Related to Rust Polars enhancement New feature or an improvement of an existing feature ci Related to the continuous integration setup accepted Ready for implementation P-low Priority: low labels Oct 11, 2024
@github-project-automation github-project-automation bot moved this to Ready in Backlog Oct 11, 2024
@stinodego
Copy link
Member

Honestly I think we should simply delete the examples folder. We have plenty of examples in the user guide now.

@rodrigogiraoserrao
Copy link
Collaborator

Honestly I think we should simply delete the examples folder. We have plenty of examples in the user guide now.

I subscribe to this.

@stinodego stinodego mentioned this issue Oct 24, 2024
Merged
@github-project-automation github-project-automation bot moved this from Ready to Done in Backlog Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stinodego stinodego

Labels
accepted Ready for implementation ci Related to the continuous integration setup documentation Improvements or additions to documentation enhancement New feature or an improvement of an existing feature P-low Priority: low rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Remove code in examples folder in favor of the user guide pola-rs/polars
3 participants
@stinodego @rodrigogiraoserrao @nameexhaustion