Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove code in examples folder in favor of the user guide #19430

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

stinodego
Copy link
Member

Closes #19186

For now the examples folder remains because some tests rely on the datasets subfolder. We can look at this later to find a better solution.

@stinodego stinodego changed the title chore: Remove code in examples folder in favor of user guide chore: Remove code in examples folder in favor of the user guide Oct 24, 2024
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.05%. Comparing base (1452468) to head (dd0a7e2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #19430       +/-   ##
===========================================
- Coverage   79.97%   60.05%   -19.93%     
===========================================
  Files        1533     1533               
  Lines      210916   210916               
  Branches     2442     2442               
===========================================
- Hits       168688   126656    -42032     
- Misses      41673    83705    +42032     
  Partials      555      555               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego marked this pull request as ready for review October 24, 2024 14:32
@ritchie46 ritchie46 merged commit ddef44f into main Oct 24, 2024
18 checks passed
@ritchie46 ritchie46 deleted the remove-examples branch October 24, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Rust examples in examples/ folder in CI
2 participants