Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Fix quadratic in binview growable same source #15734

Merged
merged 1 commit into from
Apr 18, 2024
Merged

perf: Fix quadratic in binview growable same source #15734

merged 1 commit into from
Apr 18, 2024

Conversation

ritchie46
Copy link
Member

fixes #15615

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Apr 18, 2024
@ritchie46 ritchie46 merged commit 252e4cf into main Apr 18, 2024
19 checks passed
@ritchie46 ritchie46 deleted the binview branch April 18, 2024 08:53
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 18, 2024

CodSpeed Performance Report

Merging #15734 will not alter performance

Comparing binview (3a65f6d) with main (86a6cfe)

Summary

✅ 22 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grouping to list of struct is slower in 0.20.6 than in 0.20.5 and leads to out-of-memory eventually
1 participant
@ritchie46